Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pack single files in tar #21

Closed
dereulenspiegel opened this issue Dec 16, 2015 · 3 comments
Closed

Don't pack single files in tar #21

dereulenspiegel opened this issue Dec 16, 2015 · 3 comments

Comments

@dereulenspiegel
Copy link

Hi!

Really great role. We use it a lot. Some Linux users have complained that the generated tar archive contains only files and not a folder containing files. So it would be nice to put the files in folder named like the archive and then create an archive of the folder. Just a detail.

Thanks!

@conorsch
Copy link
Contributor

@dereulenspiegel This has bothered me for a while too, but the role is so otherwise so strong I've put up with it. As you may have noticed, as of #44 the role is now using zip rather than tar, but the lack of a nested directory still persists, so your initial objection is still valid.

Does anyone else have strong feelings here?

@xahare
Copy link

xahare commented Feb 24, 2017

Ive been using this role for years, and this has also bugged me. never thought to bring it up till i saw this thread.

@conorsch
Copy link
Contributor

conorsch commented Mar 1, 2017

Given that the role now uses zip rather than tar archives, we're stuck with the current unnested behavior. (Reading through man zip didn't show any relevant options here to change the behavior.) Rather than complicate the role with extra tasks to copy files to temporary directories prior to zipping, let's accept this minor limitation and focus on other issues.

@conorsch conorsch closed this as completed Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants