Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin interface #99

Merged
merged 10 commits into from
Dec 31, 2020
Merged

Plugin interface #99

merged 10 commits into from
Dec 31, 2020

Conversation

str4d
Copy link
Owner

@str4d str4d commented Apr 7, 2020

Current specification:

https://hackmd.io/@str4d/age-plugin-spec

Plugin functionality is being merged behind the unstable feature flag, so expect that it might be adjusted in subsequent releases while we figure out the gaps.

@str4d str4d added the enhancement New feature or request label Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #99 (2339c42) into master (78e23e4) will decrease coverage by 5.09%.
The diff coverage is 8.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   39.93%   34.83%   -5.10%     
==========================================
  Files          25       31       +6     
  Lines        2061     2687     +626     
==========================================
+ Hits          823      936     +113     
- Misses       1238     1751     +513     
Impacted Files Coverage Δ
age-plugin/examples/age-plugin-unencrypted.rs 0.00% <0.00%> (ø)
age-plugin/src/identity.rs 0.00% <0.00%> (ø)
age-plugin/src/recipient.rs 0.00% <0.00%> (ø)
age/src/error.rs 0.00% <0.00%> (ø)
age/src/lib.rs 100.00% <ø> (ø)
age/src/plugin.rs 0.00% <0.00%> (ø)
age/src/protocol/decryptor.rs 41.93% <ø> (ø)
rage/src/bin/rage/error.rs 0.00% <0.00%> (ø)
age/src/cli_common.rs 16.07% <11.11%> (+16.07%) ⬆️
age/src/identity.rs 50.00% <15.38%> (-9.10%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e23e4...2339c42. Read the comment docs.

@str4d str4d mentioned this pull request Apr 7, 2020
@str4d str4d force-pushed the plugin-interface branch 7 times, most recently from ee5139f to a6ec565 Compare April 27, 2020 03:19
@str4d str4d force-pushed the plugin-interface branch 4 times, most recently from d94e73b to 5416437 Compare August 17, 2020 11:44
@str4d str4d force-pushed the plugin-interface branch 3 times, most recently from 0304278 to 057cfa9 Compare August 31, 2020 00:04
@str4d str4d force-pushed the plugin-interface branch 9 times, most recently from a14a72c to 8a00dbe Compare November 10, 2020 02:31
rage/src/bin/rage-mount/main.rs Outdated Show resolved Hide resolved
rage/src/bin/rage/error.rs Outdated Show resolved Hide resolved
rage/src/bin/rage/error.rs Outdated Show resolved Hide resolved
@str4d str4d force-pushed the plugin-interface branch 2 times, most recently from 5339a35 to fea1d14 Compare November 14, 2020 15:45
@str4d str4d marked this pull request as ready for review December 30, 2020 05:00
This enables support to be merged (and part of crate releases) before the
plugin spec is finalised.
This enables users to e.g. install USB-requiring age plugins in the
Windows host, and a rage binary installed in a WSL guest will
transparently use them.
@str4d
Copy link
Owner Author

str4d commented Dec 31, 2020

Calling it unstable! We can figure out the rest in subsequent PRs.

@str4d str4d merged commit 2c57cbc into master Dec 31, 2020
@str4d str4d deleted the plugin-interface branch December 31, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant