Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building:min_level of building:part is ignored #144

Open
kayD opened this issue Jun 30, 2023 · 1 comment
Open

building:min_level of building:part is ignored #144

kayD opened this issue Jun 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@kayD
Copy link

kayD commented Jun 30, 2023

A building:part that specifies building:min_level is handled as if this attribute is ignored.

Expected behavior
If for example a building:min_level=1 is specified, then the ground level should be empty/not filled.

Example 1
https://www.openstreetmap.org/way/1174378874#map=19/49.78869/9.93246
https://streets.gl/#49.78877,9.93248,45.00,17.57,89.69
image
The goldenrod building part should only be level 1, level 0 (ground) should not be there.

Example 2
A two-floor building, level 0 should be white, level 1 should be brown.
level 0: https://www.openstreetmap.org/way/1174541749
level 1: https://www.openstreetmap.org/way/1174541748
https://streets.gl/#50.49784,9.94346,45.00,0.00,112.93
image
The brown top floor is rendered also for the ground floor, conflicting with the white colour.

Additional context
Please note that this seems unrelated to the problem about rendering building outlines when building:part geometry is present, which is handled in #3
I do recall that this worked before, but not 100% sure any more.

@kayD kayD added the bug Something isn't working label Jun 30, 2023
@kayD
Copy link
Author

kayD commented Jan 2, 2024

I think this bug has been fixed in the meantime by @StrandedKitty: the location mentioned in the original post now looks like this:
Screenshot_20240102_125506
Which is the expected rendering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant