Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pymongo 3 #205

Merged
merged 3 commits into from
Oct 30, 2017
Merged

Conversation

furushchev
Copy link
Collaborator

This pull request contains:

@furushchev
Copy link
Collaborator Author

furushchev commented Oct 23, 2017

Just a comment:
It's better to test on ubuntu 14.04 (=indigo) / 16.04 (=kinetic) and with daemon / without daemon for make this package more reliable.

14.04 uses pymongo 2.6
16.04 uses pymongo 3.2

To test using daemon, test file should be like:

<launch>
  <!-- mostly copied from mongodb_store/tests/message_store.test -->
  <param name="mongodb_use_daemon" value="true" />
  <param name="mongodb_port" value="27017" />
  <param name="mongodb_host" value="localhost" />

  <!--
  <node name="mongo_server" pkg="mongodb_store" type="mongodb_server.py">
    <param name="test_mode" value="true"/>
  </node>
  -->

  <node name="message_store" pkg="mongodb_store" type="message_store_node.py"/>

  <!-- rosout and diagnostic topic logger -->
  <!-- <node name="diagnostics_logger" pkg="strands_diagnostics" type="logger"/> -->
  
  <test test-name="test_messagestore" pkg="mongodb_store" type="test_messagestore.py" />

</launch>

@hawesie hawesie merged commit 72d1894 into strands-project:kinetic-devel Oct 30, 2017
@hawesie
Copy link
Member

hawesie commented Oct 30, 2017

Thanks for the code!

@furushchev please can you explain the comment above about testing with different configurations? I don't quite follow it.

@furushchev
Copy link
Collaborator Author

@hawesie We currently use mongodb in 2 ways: using mongodb_server.py which spawns mongod instance or using system mongod (I called daemon in the previous comment) and in client side, there are two logics to check if mongodb server is alive or not for both cases. So we need to check both cases.
Also this package is released for indigo and kinetic which is run on ubuntu 14.04 / 16.04 respectively so it is better to test on both OS versions.
So my suggestion is to test on env:

# Ubuntu ROS mongodb server
1 14.04 indigo mongodb_server.py
2 14.04 indigo system mongod
3 16.04 kinetic mongodb_server.py
4 16.04 kinetic system mongod

@furushchev furushchev deleted the pymongo3 branch October 30, 2017 09:52
@hawesie
Copy link
Member

hawesie commented Oct 30, 2017

Created a new issue for this in #208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_connection_to_mongod doesn't work with more recent versions of pymongo
2 participants