Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 10: Authorization with Can Can Can #10

Merged
merged 11 commits into from
Feb 2, 2023
Merged

Conversation

topeogunleye
Copy link
Collaborator

@topeogunleye topeogunleye commented Feb 2, 2023

Milestone 10: Authorization with Can Can Can

In this Pull Request, We:

  • Installed CanCanCan in the project.
  • Added a role column to the users table.
  • Added functionality for user to delete a post if they're logged in and owners of that post.
    • We added delete button and functionality for comments and posts.

Copy link

@arslanbisharat arslanbisharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @topeogunleye,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • The Pull Request has a proper title and description. ✔️
  • You have added a descriptive Readme file. Good Job. ✔️
  • There is no linter error is present. ✔️
  • Project has met all the technical aspects you needed for this project. Keep rocking! ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • Please make sure you right descriptive comments. Commenting involves placing Human Readable Descriptions inside of computer programs detailing what the Code is doing. Proper use of commenting can make code maintenance much easier, as well as helping make finding bugs faster. Further, commenting is very important when writing functions that other people will use. ❌

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

app/models/ability.rb Outdated Show resolved Hide resolved
app/models/user.rb Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
@Strangeal
Copy link
Owner

Thank you @arslanbisharat

Copy link

@rustam-tolipov rustam-tolipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @topeogunleye,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Developer-512px-10

Highlights

  1. No Linters errors 💯
  2. All requirements are complete 💯

Optional suggestions

No optional suggestions :)

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Strangeal
Copy link
Owner

Thank you

@Strangeal Strangeal merged commit 6d9d00a into dev Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants