Implemented: Validations and model spec #3
Conversation
There was a problem hiding this comment.
Hello @Strangeal 👋
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Good job with your testing 👍
Required Changes
- On your readme file please let the potential users know how they can test your app and what are the prerequisites to install in order to test.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! clapclapclap
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Project Approved 🏆 🎉
Hi @Strangeal,
Your project is complete! You have done it exceptionally well. it's time to merge it 💯
Congratulations! 🎉
To Highlight 👍
✔️ No linter error.
✔️ Descriptive readme file.
✔️ Well-implemented suggestions.
Optional suggestions 🔽
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
- The commit message should be written in the imperative tense and the first letter should also be capitalized.
Ex: "Fix bug" instead of "fix bug".For more details...
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification. You can also connect with me on slack
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
@mahbubul14 Thank you |
In this PR, I added
RSpecto this project to write test for models and also added somevalidationsas per requirements. Below are the features I added:UserandPostmodels:NameandTitlemust not be blank.Titlemust not exceed250characters.PostsCounter,CommentsCounterandLikesCountermust be anintegergreater than or equal to zero.models,methodsandvalidations.