Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Devise authentication #9

Merged
merged 8 commits into from
Feb 1, 2023
Merged

Conversation

Strangeal
Copy link
Owner

In this PR, I added devise gem authentication and other features according to the project requirements. Below are the features I added:

  • Removed current_user method in ApplicationController
  • Installed and setup devise gem in my gemfile
  • Implemented operations user can perform after adding devise gem
    • User can create a new account
    • User logs in with a combination of email and password
    • Can reset password.
    • User can update password after log in

Copy link

@descholar-ceo descholar-ceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Strangeal ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

👍🏽 Professional PR ✔️
👍🏽 Linters installed and they show no error ✔️

Required Changes ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

app/models/user.rb Outdated Show resolved Hide resolved
Copy link

@rustam-tolipov rustam-tolipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Strangeal,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Developer-512px-10

Highlights

  1. No Linters errors 💯
  2. All requirements are complete 💯

Optional suggestions

No optional suggestions :)

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Strangeal Strangeal merged commit 50c2c51 into dev Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants