PayPal Express Transaction ID wrong on recurring orders.

[andrewlimaza]

Describe the bug
When a recurring membership level's order is created, the transaction_id value is set to the subscription_id.

This only happens on recurring membership orders with PayPal Express.

To Reproduce
Steps to reproduce the behavior:

1. Create a recurring membership level.
2. Checkout for this level using PayPal Express.
3. Navigate to the recently created order and notice that the transaction_id is the same as the subscription_id.

Isolating the problem (mark completed items with an [x]):

• I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
• This bug happens with a default WordPress theme active, or Memberlite.
• I can reproduce this bug consistently using the steps above.

[mircobabini]

Even if PayPal docs says that CreateRecurringPaymentsProfile Response Fields are:

• PROFILEID
• PROFILESTATUS
• TRANSACTIONID

In fact this is not the case. Instead:

• PROFILEID, always set
• PROFILESTATUS, sometimes is missing. When missing, means error.
• TRANSACTIONID, never set

So, at this moment, the only way to get the missing TRANSACTIONID would be:

• collect the PROFILEID (I-xxxxxxx)
• call the method $morder->Gateway->getRealPaymentTransactionId( $morder ) which was written exactly to recover the real TRANSACTIONID for order set with TRANSACTIONID=PROFILEID (all PayPal Express orders).

But, first of all, we must avoid to set as status=success orders on which initial payment failed. As proposed here and discussed in the linked issue.

[tictag]

MODS ONLY Further information on this, including screenshots, are available in plus support ticket: https://www.paidmembershipspro.com/forums/topic/bugfix-paypal-express-transaction-v-subscription-ids-in-order

[mircobabini]

Update: checking NVP PayPal official deprecated documentation...

That line of the doc is buggy. The initial_payment_txn_id is always provided on new profile created message, while it's not passed on recurring payments.

This means that we can update the order transaction_id as soon as we receive the recurring_payment_profile_created ipn message.

To sum up:

1. During checkout process, we can use $morder->Gateway->getRealPaymentTransactionId( $morder ) to get the only payment collected which is the initial payment and save the order using the correct payment id.
2. As soon as we receive the ipn recurring_payment_profile_created ipn message, we can make sure the transaction_id was collected during the checkout or force it to update and throw a warning.

[mircobabini]

Fixed by 67573a1: as soon as the real transaction_id comes, it's replaced.

[dparker1005]

Closing as resolved