Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong system font on Safari #629

Closed
tomtuv opened this issue Jun 16, 2022 · 0 comments · Fixed by #630
Closed

Wrong system font on Safari #629

tomtuv opened this issue Jun 16, 2022 · 0 comments · Fixed by #630
Labels
issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: icons relates to icons package status: pending reproduction Waiting for free time to reproduce the issue, or more information

Comments

@tomtuv
Copy link

tomtuv commented Jun 16, 2022 •
edited
Loading

Bug report

Required System information

  • Node.js version: 16.13.0
  • NPM version: 8.10.0
  • Strapi version: 4.2.0
  • Database: MySQL
  • Operating system: macOS 12.4

Describe the bug

The content manager is not using the system font on Safari, Helvetica Neue is used instead of San Francisco. The bug is not present in other browsers.

Steps to reproduce the behavior

Use a Safari extension like WhatFont to inspect the fonts on the page.

Expected behavior

San Francisco should be used instead of Helvetica Neue as it is the macOS system font.

Screenshots

Capture d’écran 2022-06-16 à 19 11 24

Code snippets

design-system/packages/strapi-design-system/src/ThemeProvider/ThemeProvider.js

Line 156 in 6101299

font-family: --apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen, Ubuntu, Cantarell, 'Open Sans', 'Helvetica Neue', sans-serif;

https://github.com/strapi/strapi/blob/5cbb60ce4b652e84dd8d65ffa2713437ecb4e619/packages/core/admin/admin/src/content-manager/components/Wysiwyg/EditorStylesContainer.js#L19

Additional context

This can be fixed by replacing --apple-system with -apple-system which is the correct font family name.
@tomtuv tomtuv changed the title Wrong system font in Safari Wrong system font on Safari Jun 16, 2022
@derrickmehaffy derrickmehaffy added issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: icons relates to icons package status: pending reproduction Waiting for free time to reproduce the issue, or more information labels Jun 16, 2022
@gu-stav gu-stav transferred this issue from strapi/strapi Jun 21, 2022
This was referenced Jun 21, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: icons relates to icons package status: pending reproduction Waiting for free time to reproduce the issue, or more information
Projects
No open projects
Content Platform Squad
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DS: Fix global apple system font-family strapi/design-system
2 participants
@derrickmehaffy @tomtuv