Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strapi is not using the configured host when launching the server #5399

Closed
fodkastir opened this issue Mar 3, 2020 · 3 comments · Fixed by #5486
Closed

Strapi is not using the configured host when launching the server #5399

fodkastir opened this issue Mar 3, 2020 · 3 comments · Fixed by #5486
Labels
good first issue Good for newcomers issue: enhancement Issue suggesting an enhancement to an existing feature severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:strapi Source is core/strapi package

Comments

@fodkastir
Copy link
Contributor

Describe the bug
Strapi is not using the configured host when spinning up the server

Steps to reproduce the behavior
Even the host that you want to launch your server is configurable but actually Strapi in not using it.
In Strapi.js, Strapi launches the sever by doing this.server.listen(this.config.port, async err instead of this.server.listen(this.config.port, this.config.host, async err, which means Node will listen to 0.0.0.0 by default.
There was an issue #3525 opened but closed without a fix.

Expected behavior
Strapi should use the host value in config when launching the server.

Additional context
Add any other context about the problem here.
@derrickmehaffy
Copy link
Member

@fodkastir please do feel free to submit a PR

@lauriejim lauriejim added good first issue Good for newcomers severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:strapi Source is core/strapi package issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 9, 2020
@lauriejim
Copy link
Contributor

Thank you for reporting that. Ping @alexandrebodin

@alexandrebodin
Copy link
Member

Yep It is a really simple fix for sure :) If you are willing to open a PR @fodkastir it would be awesome 💯

@fodkastir fodkastir mentioned this issue Mar 10, 2020
Merged
alexandrebodin added a commit that referenced this issue Mar 11, 2020
@alexandrebodin
Merge pull request #5486 from fodkastir/master
7873579 
fix #5399 Strapi is not using the configured host when launching the server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers issue: enhancement Issue suggesting an enhancement to an existing feature severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #5399 Strapi is not using the configured host when launching the server fodkastir/strapi
4 participants
@lauriejim @alexandrebodin @derrickmehaffy @fodkastir