Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5399 Strapi is not using the configured host when launching the server #5486

Merged
merged 1 commit into from Mar 11, 2020

Conversation

fodkastir
Copy link
Contributor

@fodkastir fodkastir commented Mar 10, 2020

Description of what you did:

Strapi does not the host value in the configuration when launching the server currently. Therefore, Node server listens on all interface when host value is omitted. This causes a problem when the user has other applications that run on the same port but different interfaces.

Fix #5399.

Signed-off-by: Yen <fodkastir@gmail.com>
@derrickmehaffy
Copy link
Member

derrickmehaffy commented Mar 10, 2020

I'm fine with this change, but something to note that if users (improperly) configured their host without the proxy block this will break their applications.

(As in using a domain instead of an IP binding)

Maybe something to note in a migration guide.

Edit: Also for production/staging, docs need to be made to explain on setting their host to something like 0.0.0.0 especially in cases like heroku

@alexandrebodin
Copy link
Member

Hi @fodkastir, can you please mention the issue you are fixing in your comment :)

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #5486 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5486   +/-   ##
=======================================
  Coverage   17.73%   17.73%           
=======================================
  Files         687      687           
  Lines       10151    10151           
  Branches     1643     1643           
=======================================
  Hits         1800     1800           
  Misses       6961     6961           
  Partials     1390     1390           
Flag Coverage Δ
#front 13.14% <ø> (ø)
#unit 37.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b1b30...222903b. Read the comment docs.

@fodkastir
Copy link
Contributor Author

@alexandrebodin I have edited my comment.

@alexandrebodin
Copy link
Member

@fodkastir I meant can you add a link to the issue :)

@fodkastir
Copy link
Contributor Author

@alexandrebodin got it and it is done.

@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 11, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 7873579 into strapi:master Mar 11, 2020
nabeelvalley added a commit to nabeelvalley/SalaahTimesApp that referenced this pull request Mar 31, 2020
nabeelvalley added a commit to nabeelvalley/SalaahTimesApp that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strapi is not using the configured host when launching the server
3 participants