New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #5399 Strapi is not using the configured host when launching the server #5486
Conversation
Signed-off-by: Yen <fodkastir@gmail.com>
I'm fine with this change, but something to note that if users (improperly) configured their host without the proxy block this will break their applications. (As in using a domain instead of an IP binding) Maybe something to note in a migration guide. Edit: Also for production/staging, docs need to be made to explain on setting their host to something like 0.0.0.0 especially in cases like heroku |
Hi @fodkastir, can you please mention the issue you are fixing in your comment :) |
Codecov Report
@@ Coverage Diff @@
## master #5486 +/- ##
=======================================
Coverage 17.73% 17.73%
=======================================
Files 687 687
Lines 10151 10151
Branches 1643 1643
=======================================
Hits 1800 1800
Misses 6961 6961
Partials 1390 1390
Continue to review full report at Codecov.
|
@alexandrebodin I have edited my comment. |
@fodkastir I meant can you add a link to the issue :) |
@alexandrebodin got it and it is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
as per note from DMehaffy and strapi/strapi#5486
as per note from DMehaffy and strapi/strapi#5486
Description of what you did:
Strapi does not the host value in the configuration when launching the server currently. Therefore, Node server listens on all interface when host value is omitted. This causes a problem when the user has other applications that run on the same port but different interfaces.
Fix #5399.