Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] Fix CM permissions with locales #11704

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril@strapi.io

What does it do?

It fixes the CM's permissions when a role does not have a locale property.

Signed-off-by: soupette <cyril@strapi.io>
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good job !!

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #11704 (7e8a11b) into releases/v4 (d6c366c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           releases/v4   #11704   +/-   ##
============================================
  Coverage        47.07%   47.07%           
============================================
  Files              211      211           
  Lines             8116     8116           
  Branches          1782     1782           
============================================
  Hits              3821     3821           
  Misses            3527     3527           
  Partials           768      768           
Flag Coverage Δ
front ?
unit 47.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e3598...7e8a11b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants