Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Upgrade Knex to latest version and swap unsupported sqlite3 fork #12557

Closed
wants to merge 8 commits into from
Closed

[WIP] Upgrade Knex to latest version and swap unsupported sqlite3 fork #12557

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a87ba51
Upgrade Knex to latest version and swap unsupported sqlite3 fork
derrickmehaffy Feb 16, 2022
f10db79
move bettersql and mysql2 into this PR
derrickmehaffy Mar 21, 2022
bc93388
Adjust everything to make better-sqlite3 the default
derrickmehaffy Mar 21, 2022
c428888
Merge branch 'master' into feature/knex-v1
derrickmehaffy Mar 21, 2022
53fc5a9
Try testing with better-sqlite3
derrickmehaffy Mar 21, 2022
5fc3b28
change all instances of sqlite to sqlite3
derrickmehaffy Mar 21, 2022
ffca9de
add primary key to join columns
derrickmehaffy Mar 21, 2022
bdd9226
I'm stuck please send help
derrickmehaffy Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/database/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"date-fns": "2.22.1",
"debug": "4.3.1",
"fs-extra": "10.0.0",
"knex": "0.95.6",
"knex": "1.0.3",
"lodash": "4.17.21",
"umzug": "2.3.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/generators/app/lib/utils/db-client-dependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const sqlClientModule = {
mysql: { mysql: '2.18.1' },
postgres: { pg: '8.6.0' },
sqlite: { sqlite3: '5.0.2' },
sqlite: { '@vscode/sqlite3': '5.0.7' },
alexandrebodin marked this conversation as resolved.
Show resolved Hide resolved
};

/**
Expand Down