New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade Knex to latest version and swap unsupported sqlite3 fork #12557
Conversation
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #12557 +/- ##
==========================================
- Coverage 47.78% 47.75% -0.04%
==========================================
Files 231 231
Lines 8619 8625 +6
Branches 1922 1927 +5
==========================================
Hits 4119 4119
- Misses 3701 3706 +5
- Partials 799 800 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Needs more testing |
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
super-seeded by: #12918 (Of course alex is a boss) |
Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com
Upgrades Knex to latest version (v1.0.3) and swaps out mapbox's node-sqlite3 for Microsoft's @vscode/sqlite3 instead
Also adds two new dialects from Knex:
I've set the default in this PR to make better-sqlite3 the default instead of sqlite, we should consider dropping normal sqlite3 in the future.
mysql2 is required for MySQL v8+ and it's new auth mechanism, we should consider dropping mysql dialect in the future.