Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mysql2 dialect to support MySQL v8 auth #12558

Closed
wants to merge 2 commits into from

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Feb 16, 2022

Requires this PR to be merged first: #12557

Add's a hybrid dialect (based on mysql client) to support the mysql2 dialect which is needed for the new auth system introduced in MySQL 8 without using native passwords


I do not plan to add these as choices for users to pick from when creating new projects as these should be considered unstable. If all goes well in testing maybe in Strapi v5 we can depreciate the mysql client and dialect and only use mysql2 but we will need to validate this with MariaDB


To-Do:

  • add tests

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #12558 (1cb6460) into master (81934f5) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12558      +/-   ##
==========================================
- Coverage   47.59%   47.58%   -0.01%     
==========================================
  Files         210      210              
  Lines        8192     8193       +1     
  Branches     1857     1858       +1     
==========================================
  Hits         3899     3899              
- Misses       3531     3532       +1     
  Partials      762      762              
Flag Coverage Δ
front ?
unit 47.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/database/lib/dialects/index.js 16.66% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81934f5...1cb6460. Read the comment docs.

@derrickmehaffy derrickmehaffy added issue: enhancement Issue suggesting an enhancement to an existing feature source: core:database Source is core/database package labels Feb 16, 2022
@alexandrebodin alexandrebodin added pr: enhancement This PR adds or updates some part of the codebase or features and removed issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 2, 2022
@derrickmehaffy
Copy link
Member Author

Closing and merging this into #12557

@alexandrebodin alexandrebodin deleted the feature/dbd-mysql2 branch June 30, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:database Source is core/database package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants