Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CM: Fix sync layouts in case no relation is set #12690

Merged
merged 3 commits into from
Mar 8, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Feb 28, 2022

What does it do?

This adds an e2e test and fix for #12582.

Why is it needed?

To allow empty relations.

How to test it?

Admin UI

  1. Create a content type with a relation
  2. Configure the view for the relation
  3. Verify the field shows up
  4. Remove the field
  5. Validate the field doesn't show up
  6. Restart the server
  7. Validate the field doesn't show up

Create a new content type by hand

  1. Create a new content type by hand and add a relation field
  2. Start the server
  3. Navigate in the CTB to configure the view
  4. Validate the field shows up

Related issue(s)/PR(s)

Fixes: #12582

@gu-stav gu-stav changed the title CM: Add e2e test for resetted relations after server restart CM: Fix sync layouts in case no relation is set Feb 28, 2022
@gu-stav gu-stav added issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package labels Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #12690 (d309628) into master (af7c3d5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12690      +/-   ##
==========================================
- Coverage   47.63%   47.62%   -0.02%     
==========================================
  Files         228      228              
  Lines        8515     8517       +2     
  Branches     1898     1900       +2     
==========================================
  Hits         4056     4056              
- Misses       3665     3667       +2     
  Partials      794      794              
Flag Coverage Δ
front ?
unit 47.62% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ger/server/services/utils/configuration/layouts.js 14.47% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7c3d5...d309628. Read the comment docs.

@alexandrebodin alexandrebodin added pr: fix This PR is fixing a bug and removed issue: bug Issue reporting a bug labels Mar 2, 2022
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 4.1.3 milestone Mar 8, 2022
@derrickmehaffy derrickmehaffy merged commit 086c449 into master Mar 8, 2022
@derrickmehaffy derrickmehaffy deleted the fix/edit-relations-restart branch March 8, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't leave relational fields empty in configure the view
3 participants