Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTB] Add format examples in date field select #12871

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

soupette
Copy link
Contributor

What does it do?

It adds format examples in date field select:

Screenshot 2022-03-17 at 09 14 14

Why is it needed?

So users have information about the format they are choosing.

How to test it?

  1. Go to the CTB
  2. Click on add new field and choose the Date one
  3. See the date format example

Signed-off-by: soupette <cyril@strapi.io>
Signed-off-by: soupette <cyril@strapi.io>
Signed-off-by: soupette <cyril@strapi.io>
@soupette soupette requested a review from Convly March 17, 2022 08:15
@soupette soupette added source: core:content-type-builder Source is core/content-type-builder package pr: enhancement This PR adds or updates some part of the codebase or features labels Mar 17, 2022
@soupette soupette added this to the 4.1.6 milestone Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #12871 (489f7a3) into master (f880ec4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12871   +/-   ##
=======================================
  Coverage   47.78%   47.78%           
=======================================
  Files         231      231           
  Lines        8619     8619           
  Branches     1922     1922           
=======================================
  Hits         4119     4119           
  Misses       3701     3701           
  Partials      799      799           
Flag Coverage Δ
front ?
unit 47.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fca8a...489f7a3. Read the comment docs.

@Convly Convly self-requested a review March 18, 2022 15:51
@soupette soupette merged commit 34893fa into master Mar 21, 2022
@soupette soupette deleted the enhancement/ctb-date-field branch March 21, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: enhancement This PR adds or updates some part of the codebase or features source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants