Jest: Add .babelrc.js workaround to fix snapshot issues with v28 #13843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gu-stav
added
source: tooling
gu-stav
requested review from
alexandrebodin,
fdel-car,
Convly and
ronronscelestes
Convly
reviewed
Jul 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #13843 +/- ##
=======================================
Coverage 54.34% 54.34%
=======================================
Files 1190 1190
Lines 30194 30194
Branches 5470 5470
=======================================
Hits 16409 16409
Misses 12008 12008
Partials 1777 1777
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gu-stav
changed the title
|
Tested on a branch with the updated DS - it seems to have fixed the issue of not being able to update snapshots, thank you 🙏🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Since the
jest@28.xupdate we are running into an issue, where updating the snapshots doesn't work any longer, if jest doesn't find the babel configuration, to transform jsx. The tracking issue in jest is open since mid 2021 and it looks like as if nothing changes very soon (the bug was introduced in jest@27).The only known and working solution is to add/ rename the current babel configurations to
.babelrc.js. As a temporary workaround until the issue is fixed I'd propose we add the missing.babelrc.jsfiles to each package. I've also pulled out some of the configuration ofadminfrom webpack into the babel configuration, where it imo belongs.In addition, I've removed some transforms which are not needed anylonger, since we are using @babel/preset-env.
Alternative considered: We can not downgrade jest, because we depend on some new features.
Why is it needed?
At the moment we are running into an issue where a snapshot test can not be updated once it is located in a package. Jest will complain that
@babel/preset-reactis not found and fail to update the snapshot.Related issue(s)/PR(s)