Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Rollback to jest@26.x #13861

Merged
merged 2 commits into from Jul 27, 2022
Merged

Chore: Rollback to jest@26.x #13861

merged 2 commits into from Jul 27, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Jul 27, 2022

What does it do?

Downgrade jest to jest@26.x, because we experience too many issues, such as #13843

Why is it needed?

To have a stable release with all tests passing.

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #13861 (c197517) into master (cd963b7) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head c197517 differs from pull request most recent head c77a54f. Consider uploading reports for the commit c77a54f to get more accurate results

@@            Coverage Diff             @@
##           master   #13861      +/-   ##
==========================================
+ Coverage   56.66%   56.69%   +0.03%     
==========================================
  Files        1178      974     -204     
  Lines       28988    21660    -7328     
  Branches     5418     3504    -1914     
==========================================
- Hits        16425    12281    -4144     
+ Misses      10799     8390    -2409     
+ Partials     1764      989     -775     
Flag Coverage Δ
front 56.69% <ø> (-3.17%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/admin/admin/src/app.js 0.00% <0.00%> (ø)
packages/core/admin/admin/src/index.js 0.00% <0.00%> (ø)
packages/core/email/admin/src/index.js 0.00% <0.00%> (ø)
packages/core/upload/admin/src/index.js 0.00% <0.00%> (ø)
packages/plugins/i18n/admin/src/index.js 0.00% <0.00%> (ø)
packages/plugins/i18n/admin/src/schemas.js 0.00% <0.00%> (ø)
packages/plugins/i18n/admin/src/permissions.js 0.00% <0.00%> (ø)
packages/core/upload/admin/src/pages/App/index.js 0.00% <0.00%> (ø)
...ckages/plugins/i18n/admin/src/middlewares/index.js 0.00% <0.00%> (ø)
...kages/core/content-type-builder/admin/src/index.js 0.00% <0.00%> (ø)
... and 409 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd963b7...c77a54f. Read the comment docs.

@gu-stav gu-stav added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Jul 27, 2022
@gu-stav gu-stav added this to the 4.3.0 milestone Jul 27, 2022
@gu-stav gu-stav requested review from Convly and petersg83 July 27, 2022 10:49
@gu-stav gu-stav marked this pull request as ready for review July 27, 2022 10:50
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Convly Convly merged commit c1366d4 into master Jul 27, 2022
@Convly Convly deleted the fix/rollback-jest-26 branch July 27, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants