Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload: Make metrics tests compatible with jest@26 #13862

Merged
merged 3 commits into from Jul 27, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Jul 27, 2022

What does it do?

#13721 introduced a test which is dependent on jest@v28. We had to downgrade jest in #13861 to v26, because it created too many problems.

This PR aims to make test compatible with jest@v26.

@gu-stav gu-stav changed the title Fix/tests jest 26 compatible Upload: Make metrics tests compatible with jest@26 Jul 27, 2022
@gu-stav gu-stav requested review from petersg83 and Convly July 27, 2022 11:00
@gu-stav gu-stav marked this pull request as ready for review July 27, 2022 11:00
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #13862 (d886f50) into features/ML-folder (9b32167) will decrease coverage by 7.02%.
The diff coverage is 76.27%.

@@                  Coverage Diff                   @@
##           features/ML-folder   #13862      +/-   ##
======================================================
- Coverage               55.22%   48.19%   -7.03%     
======================================================
  Files                    1223      245     -978     
  Lines                   31101     9088   -22013     
  Branches                 5689     2005    -3684     
======================================================
- Hits                    17174     4380   -12794     
+ Misses                  12134     3883    -8251     
+ Partials                 1793      825     -968     
Flag Coverage Δ
front ?
unit 48.19% <76.27%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tent-type-builder/server/services/content-types.js 27.18% <ø> (ø)
...erver/services/schema-builder/component-builder.js 14.03% <0.00%> (ø)
...er/services/schema-builder/content-type-builder.js 8.73% <ø> (ø)
...pe-builder/server/services/schema-builder/index.js 10.14% <0.00%> (ø)
packages/core/database/lib/migrations/index.js 30.00% <0.00%> (ø)
packages/core/strapi/lib/services/metrics/index.js 61.53% <0.00%> (-2.47%) ⬇️
packages/core/upload/server/middlewares/upload.js 66.66% <ø> (ø)
packages/core/admin/server/controllers/admin.js 34.93% <12.50%> (-2.40%) ⬇️
...b/sanitize/visitors/remove-restricted-relations.js 62.16% <85.71%> (+53.07%) ⬆️
...ges/core/admin/utils/get-custom-app-config-file.js 100.00% <100.00%> (ø)
... and 1030 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3c08b...d886f50. Read the comment docs.

@gu-stav gu-stav merged commit 8f32d44 into features/ML-folder Jul 27, 2022
@gu-stav gu-stav deleted the fix/tests-jest-26-compatible branch July 27, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant