Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default timezone to UTC for SQL database #1437

Merged
merged 3 commits into from
Jun 26, 2018

Conversation

johannpinson
Copy link
Contributor

My PR is a:
🐛 Bug fix

Main update on the:
Admin
Plugin

This PR fix the bug about timezone transformation when you save a date/datetime/time/timestamp with a SQL database.

I added the ability to change this settings, but in fact, I don't recommand it.
Do I have to change it?

It also contains an improvement for both type of database about the use of .utc() in the admin.

@johannpinson johannpinson changed the title fix(admin): change timezone manager from admin when db is sql Fix default timezone to UTC for SQL database Jun 20, 2018
@lauriejim lauriejim self-assigned this Jun 20, 2018
@lauriejim lauriejim added pr: 🐛 Bug fix source: core:strapi Source is core/strapi package labels Jun 20, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.12.6 milestone Jun 20, 2018
@Aurelsicoko
Copy link
Member

@johannpinson Can you also update the documentation? What kind of values are allowed in this new settings timezone?

@johannpinson
Copy link
Contributor Author

@Aurelsicoko docs updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants