New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logo #14809
Update logo #14809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanksssss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I've added another commit to compress the PNGs a bit better (saves about 14kB).
One thing I find a bit odd: we currently have two logos with different border radi:
logo_strapi_auth_v4.png | logo_strapi_menu.png |
---|---|
@maevalienard Do you see a way to unify both, so that we only have to maintain one version?
Good catch @gu-stav, I'll compress them and update the logo_strapi_menu.png too, the border-radius has been updated a bit. |
@Aurelsicoko I've checked in a compressed version already in 766db8e :) It would be great, if we could get rid of one logo, because otherwise users need to download both files. |
My bad, I compressed the 3 of them and simply updated the file, we could maybe use only one as you mentioned as they are both the same (not the same size though). |
If you want I can take care of that in a follow-up PR? I've added another one to cleanup the assets a bit and could also cleanup both logos if you tell me which one to use :) |
Codecov ReportBase: 58.96% // Head: 58.96% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #14809 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 1347 1347
Lines 32666 32666
Branches 6176 6176
=======================================
Hits 19263 19263
Misses 11515 11515
Partials 1888 1888
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We should only have the one on the left. Kevin planned a very specific border-radius for the background :) |
@maevalienard Great, thanks. I'll unify both of them in a follow-up PR! |
What does it do?
I've updated the logos to match the new brand guidelines.
Why is it needed?
Describe the issue you are solving.
How to test it?
Open the sign-up and sign-in page and appreciate the new logo.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request