Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo #14809

Merged
merged 4 commits into from Nov 8, 2022
Merged

Update logo #14809

merged 4 commits into from Nov 8, 2022

Conversation

Aurelsicoko
Copy link
Member

What does it do?

I've updated the logos to match the new brand guidelines.

Why is it needed?

Describe the issue you are solving.

How to test it?

Open the sign-up and sign-in page and appreciate the new logo.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@Aurelsicoko Aurelsicoko added source: core:admin Source is core/admin package pr: enhancement This PR adds or updates some part of the codebase or features pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 8, 2022
@Aurelsicoko Aurelsicoko added this to the 4.5.0 milestone Nov 8, 2022
maevalienard
maevalienard previously approved these changes Nov 8, 2022
Copy link

@maevalienard maevalienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanksssss

Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've added another commit to compress the PNGs a bit better (saves about 14kB).

One thing I find a bit odd: we currently have two logos with different border radi:

logo_strapi_auth_v4.png logo_strapi_menu.png
logo_strapi_auth_v4 logo_strapi_menu

@maevalienard Do you see a way to unify both, so that we only have to maintain one version?

@Aurelsicoko
Copy link
Member Author

Good catch @gu-stav, I'll compress them and update the logo_strapi_menu.png too, the border-radius has been updated a bit.

@gu-stav
Copy link
Contributor

gu-stav commented Nov 8, 2022

@Aurelsicoko I've checked in a compressed version already in 766db8e :) It would be great, if we could get rid of one logo, because otherwise users need to download both files.

@Aurelsicoko
Copy link
Member Author

@Aurelsicoko I've checked in a compressed version already in 766db8e :) It would be great, if we could get rid of one logo, because otherwise users need to download both files.

My bad, I compressed the 3 of them and simply updated the file, we could maybe use only one as you mentioned as they are both the same (not the same size though).

@gu-stav
Copy link
Contributor

gu-stav commented Nov 8, 2022

If you want I can take care of that in a follow-up PR? I've added another one to cleanup the assets a bit and could also cleanup both logos if you tell me which one to use :)

@gu-stav gu-stav removed the pr: enhancement This PR adds or updates some part of the codebase or features label Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 58.96% // Head: 58.96% // No change to project coverage 👍

Coverage data is based on head (08430e9) compared to base (ea360a8).
Patch has no changes to coverable lines.

❗ Current head 08430e9 differs from pull request most recent head dff7e91. Consider uploading reports for the commit dff7e91 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14809   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files        1347     1347           
  Lines       32666    32666           
  Branches     6176     6176           
=======================================
  Hits        19263    19263           
  Misses      11515    11515           
  Partials     1888     1888           
Flag Coverage Δ
front 63.52% <ø> (ø)
unit 48.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maevalienard
Copy link

@maevalienard Do you see a way to unify both, so that we only have to maintain one version?

We should only have the one on the left. Kevin planned a very specific border-radius for the background :)

@gu-stav
Copy link
Contributor

gu-stav commented Nov 8, 2022

@maevalienard Great, thanks. I'll unify both of them in a follow-up PR!

@gu-stav gu-stav merged commit 5064a50 into main Nov 8, 2022
@gu-stav gu-stav deleted the chore/update-logo branch November 8, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants