Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Cleanup brand assets #14816

Merged
merged 2 commits into from Nov 9, 2022
Merged

Chore: Cleanup brand assets #14816

merged 2 commits into from Nov 9, 2022

Conversation

gu-stav
Copy link
Contributor

@gu-stav gu-stav commented Nov 9, 2022

What does it do?

  • Replaces Strapi logo PNGs with SVGs (smaller file-size (saves about 12kB for the login/ dashboard), improved rendering)
  • Minifies some SVGs
  • Minifies the Strapi rocket asset PNG (saves ~50kB / pageview)

Menu

Before After
Screenshot 2022-11-09 at 09 12 38 Screenshot 2022-11-09 at 09 13 01

Signin

Before After
Screenshot 2022-11-09 at 09 22 53 Screenshot 2022-11-09 at 09 22 43

Marketplace

Before After
Screenshot 2022-11-09 at 09 17 48 Screenshot 2022-11-09 at 09 18 11

Why is it needed?

Improves the amount of data that is transferred to our users and makes sure, brand assets (such as the logo) are render as good as possible.

Related issue(s)/PR(s)

@gu-stav gu-stav added source: core:admin Source is core/admin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Nov 9, 2022
@gu-stav gu-stav added this to the 4.5.0 milestone Nov 9, 2022
joshuaellis
joshuaellis previously approved these changes Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 58.99% // Head: 58.99% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (55551e4) compared to base (fe489be).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 55551e4 differs from pull request most recent head a3b0e90. Consider uploading reports for the commit a3b0e90 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14816      +/-   ##
==========================================
- Coverage   58.99%   58.99%   -0.01%     
==========================================
  Files        1349     1349              
  Lines       32698    32697       -1     
  Branches     6181     6181              
==========================================
- Hits        19291    19290       -1     
  Misses      11521    11521              
  Partials     1886     1886              
Flag Coverage Δ
front 63.55% <100.00%> (-0.01%) ⬇️
unit 48.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core/admin/admin/src/StrapiApp.js 62.55% <100.00%> (-0.18%) ⬇️
...MarketplacePage/components/NpmPackageCard/index.js 94.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@maevalienard maevalienard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gu-stav gu-stav merged commit 70281fa into main Nov 9, 2022
@gu-stav gu-stav deleted the chore/brand-assets-2 branch November 9, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants