make id arg required in singular content type graphql request

[innerdvations]

What does it do?

Makes the "id" argument in Graphql queries required for singular content type requests (eg, "restaurant" but not "restaurants" or single types)

Despite changing the schema, I do not believe it should be considered a breaking change because currently the queries are already broken, so this only corrects the type of error that is returned.

Why is it needed?

Before this PR, failing to include an id results in an invalid query that goes all the way to the database layer:

After this PR, we catch the missing ID with the graphql schema:

How to test it?

Test that id argument is now required for singular content request types that previously had only an "id" arg that wasn't required.

It should not be required for single types or multiple request queries

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +5.61 🎉

Comparison is base (b9e92de) 60.68% compared to head (e47e7d0) 66.30%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15877      +/-   ##
==========================================
+ Coverage   60.68%   66.30%   +5.61%     
==========================================
  Files        1495     1121     -374     
  Lines       36878    22792   -14086     
  Branches     7359     4191    -3168     
==========================================
- Hits        22380    15112    -7268     
+ Misses      12417     6800    -5617     
+ Partials     2081      880    -1201     

Flag	Coverage Δ
back	?
front	66.30% <ø> (ø)
unit_back	?
unit_front	66.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...content-manager/server/controllers/single-types.js
...nager/server/services/utils/configuration/index.js
packages/core/utils/lib/parse-multipart.js
...ore/strapi/lib/core-api/service/collection-type.js
...ore/content-manager/server/services/utils/store.js
...core/strapi/lib/services/metrics/stringify-deep.js
...builder/server/controllers/validation/component.js
...ages/core/strapi/lib/services/content-api/index.js
...s/core/database/lib/validations/relations/index.js
...es/plugins/i18n/server/migrations/field/migrate.js
... and 364 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Bassel17]

This change looks good to me, I think you can update this with main and it should be fine to mover forward with this fix

[aaronLejeune]

Hi all,

Had some headaches after installing this update because this commit is causing my application to break.

I want to query based on SLUG instead of ID an followed this tutorial:
https://forum.strapi.io/t/strapi-v4-search-by-slug-instead-id/13469/37

In short, this is the code we used
`register({ strapi }) {
const extensionService = strapi.plugin("graphql").service("extension");

const extension = () => ({
  typeDefs: `
    type Query {
      faqQuestion(slug: String!): FaqQuestionEntityResponse
    }
  `,
  resolvers: {
    Query: {
      faqQuestion: {
        resolve: async (parent, args, context) => {
          const { toEntityResponse } = strapi.service(
            "plugin::graphql.format"
          ).returnTypes;
          const data = await strapi.services["api::faq-question.faq-question"].find({
            filters: { slug: args.slug },
          });
          const response = toEntityResponse(data.results[0]);
          return response;
        },
      },
    },
  },
});

extensionService.use(extension);

},`

Which of course is causing this error:
Field \"faqQuestion\" argument \"id\" of type \"ID!\" is required, but it was not provided.

Any idea on how to bypass the "ID is required" issue?

It seems like a lot of developers are using that tutorial to query their contentTypes, will keep an eye out for future issues because not everyone is reading updates. Thanks a lot!

[strapi-bot]

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/strapi-v4-search-by-slug-instead-id/13469/54