Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid action mapping using unknow action #16096

Merged
merged 4 commits into from Mar 15, 2023

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Mar 15, 2023

What does it do?

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin added source: core:strapi Source is core/strapi package pr: fix This PR is fixing a bug labels Mar 15, 2023
Marc-Roig
Marc-Roig previously approved these changes Mar 15, 2023
Copy link
Contributor

@Marc-Roig Marc-Roig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an Author role, one which can only see CT entities that they have created.

Tested for custom permissions can create, read, update, delete.

Everything seems to be working , LGTM

Marc-Roig
Marc-Roig previously approved these changes Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (releases/4.8.1@e239e40). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##             releases/4.8.1   #16096   +/-   ##
=================================================
  Coverage                  ?   59.96%           
=================================================
  Files                     ?     1484           
  Lines                     ?    37322           
  Branches                  ?     7470           
=================================================
  Hits                      ?    22381           
  Misses                    ?    12758           
  Partials                  ?     2183           
Flag Coverage Δ
back 50.09% <0.00%> (?)
front 66.21% <0.00%> (?)
unit_back 50.09% <0.00%> (?)
unit_front 66.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

innerdvations
innerdvations previously approved these changes Mar 15, 2023
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, looks like it works!

Haven't looked closely at the tests tonight but otherwise seems good.

@alexandrebodin alexandrebodin changed the base branch from main to releases/4.8.1 March 15, 2023 18:42
@alexandrebodin alexandrebodin added this to the 4.8.1 milestone Mar 15, 2023
@alexandrebodin alexandrebodin merged commit 8775dcd into releases/4.8.1 Mar 15, 2023
45 checks passed
@alexandrebodin alexandrebodin deleted the hotfix/4.8.0 branch March 15, 2023 21:22
@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/strapi-v4-search-by-slug-instead-id/13469/55

@strapi-bot
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/data-gets-deleted-when-strapi-container-restarts/17412/37

@AhmadEltobshy
Copy link

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/data-gets-deleted-when-strapi-container-restarts/17412/37

I have faced the same issue, the strapi app is on an Azure container and the database is external (azure SQL database) and data get deleted each time the container restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author role not hiding forbidden items
5 participants