Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin): admin build errors #18764

Merged
merged 5 commits into from
Nov 13, 2023
Merged

fix(admin): admin build errors #18764

merged 5 commits into from
Nov 13, 2023

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Nov 13, 2023 •
edited
Loading

What does it do?

  • adds app.js as an import argument to the renderAdmin function
  • checks that the user webpack config is a typeof function otherwise show an error explaining
  • converts system paths to node_module paths so local plugins work on windows

Why is it needed?

  • App customisations were not applied to user apps
  • users were reporting that their webpack user config was not a function but being called as such
  • local plugin paths on windows were broken

Related issue(s)/PR(s)

@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 13, 2023
@joshuaellis joshuaellis self-assigned this Nov 13, 2023
@joshuaellis joshuaellis added this to the 4.15.5 milestone Nov 13, 2023
@joshuaellis joshuaellis marked this pull request as ready for review November 13, 2023 08:42
@joshuaellis joshuaellis merged commit 175b72a into main Nov 13, 2023
38 of 45 checks passed
@joshuaellis joshuaellis deleted the chore/fix-admin-customisations branch November 13, 2023 10:21
joshuaellis added a commit that referenced this pull request Nov 13, 2023
@joshuaellis
fix(admin): admin build errors (#18764)
be578ad 
* fix(admin): import & pass user customisations for admin panel

* fix(admin): modules should be resolved with module paths not system paths

* fix(admin): ensure webpack config is a type of function before calling, warn otherwise

* fix: convert the pluginPath to a system path before trying to resolve relative

* chore: update documentation
@joshuaellis joshuaellis mentioned this pull request Nov 13, 2023
Merged
joshuaellis added a commit that referenced this pull request Nov 13, 2023
@joshuaellis
fix(admin): admin build errors (#18764) (#18770)
2f026ea 
* fix(admin): import & pass user customisations for admin panel

* fix(admin): modules should be resolved with module paths not system paths

* fix(admin): ensure webpack config is a type of function before calling, warn otherwise

* fix: convert the pluginPath to a system path before trying to resolve relative

* chore: update documentation
markkaylor
markkaylor reviewed Nov 13, 2023
View reviewed changes
examples/getstarted/src/admin/app.js
Comment on lines +4 to +6
const bootstrap = () => {
console.log('I AM BOOTSTRAPPED');
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshuaellis 👀

@derrickmehaffy
Copy link
Member

@Boegie19 was testing alpha.2 on Windows and still hits the issue in #18719

image

@joshuaellis joshuaellis mentioned this pull request Nov 21, 2023
Closed
@renovate renovate bot mentioned this pull request May 2, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markkaylor markkaylor markkaylor left review comments

@gu-stav gu-stav gu-stav approved these changes

Assignees

@joshuaellis joshuaellis

Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Milestone
4.15.5
4 participants
@joshuaellis @derrickmehaffy @gu-stav @markkaylor