Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): admin build errors (#18764) #18770

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

joshuaellis
Copy link
Member

What does it do?

  • fixes admin build errors

Why is it needed?

Related issue(s)/PR(s)

  • cherry picked from main

* fix(admin): import & pass user customisations for admin panel

* fix(admin): modules should be resolved with module paths not system paths

* fix(admin): ensure webpack config is a type of function before calling, warn otherwise

* fix: convert the pluginPath to a system path before trying to resolve relative

* chore: update documentation
@joshuaellis joshuaellis added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Nov 13, 2023
@joshuaellis joshuaellis self-assigned this Nov 13, 2023
@joshuaellis joshuaellis changed the base branch from main to releases/4.15.5 November 13, 2023 12:00
@joshuaellis joshuaellis merged commit 2f026ea into releases/4.15.5 Nov 13, 2023
27 checks passed
@joshuaellis joshuaellis deleted the 4.15.5/admin-build-errors branch November 13, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants