feat(history): capture content types history #19343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
added
source: core:content-manager
Marc-Roig
reviewed
Jan 29, 2024
Marc-Roig
reviewed
Jan 29, 2024
Marc-Roig
reviewed
Jan 29, 2024
packages/core/content-manager/server/src/history/services/history.ts
Outdated
Show resolved
Hide resolved
remidej
commented
Jan 29, 2024
Comment on lines
+21
to
+29
| // Check if store already exists | ||
| const oldStore = storage.getStore(); | ||
|
|
||
| return storage.run<ReturnType<TCallback>, void[]>( | ||
| { trx: store, commitCallbacks: [], rollbackCallbacks: [] }, | ||
| { | ||
| trx: store, | ||
| commitCallbacks: oldStore?.commitCallbacks || [], | ||
| rollbackCallbacks: oldStore?.rollbackCallbacks || [], | ||
| }, |
There was a problem hiding this comment.
This fix was found by @Marc-Roig, it's because nested transactions weren't inheriting the parent transaction context. Marc will ship another dedicated PR with tests but bundling the change in this PR too allows us to move on with this PR
markkaylor
approved these changes
Jan 29, 2024
packages/core/content-manager/shared/contracts/history-versions.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+79
to
+80
| createdAt: new Date(), | ||
| createdBy: strapi.requestContext.get()?.state?.user.id, |
There was a problem hiding this comment.
Already discussed on slack but put this here anyway. I don't know how it works now but in v4 these were already set when using content-types, well you get them using an util:
There was a problem hiding this comment.
Thanks I'll look more at what this does when I implement the model API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Why is it needed?
To make history
How to test it?