fix: do not validate locale if not creating #19626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Roig
added
source: plugin:i18n
Marc-Roig
requested review from
innerdvations,
markkaylor,
joshuaellis and
jhoward1994
joshuaellis
reviewed
Feb 28, 2024
Co-authored-by: Josh <37798644+joshuaellis@users.noreply.github.com>
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
Marc-Roig
commented
Feb 28, 2024
innerdvations
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
As we discussed, neither of us like this, but it fixes the problem and there doesn't appear to be a better way 😆
I suspect that even though this will solve 99% of the cases, there will be a handful of edge cases we didn't anticipate that will have to be solved later, but we'll find out then, and it shouldn't actually break anything
jhoward1994
approved these changes
Feb 28, 2024
|
This PR did not account for query parameters so url like this |
|
@minht11 thank you for the report :) Will create a ticket with the fix today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I18n Backend koa middlweare was matching all CM routes, and validating locale creation even for actions that were not related (publishing, unpublishing)
If the API received the "relatedEntityId" param when publishing, it assumed this was for creating a new locale (and checked if the locale already existed), and failed because the action was to publish an existing locale.
My only worry here is that the url matching is not smart enough and we miss some cases
How to test?
Create single types and collection type locales, and publish them. You should not get an error
Related issues