fix:issue on do not validate locale if not creating for all locales #19799
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Marc-Roig
added
source: plugin:i18n
|
@binar1 could you run prettier to format the file you updated? 🙏 (yarn prettier:code) |
|
Hello @Marc-Roig noted. I've pushed a new commit where Prettier has been used. |
|
will run the CI and once its green will merge this work, did a quick check and seems to be working, but we will run it through a QA process during the week and release this on |
|
Looks like some tests are failing, I am taking a look now |
|
This work will be finally released in next week |
|
Great job on fixing the issue, thank you! |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/translating-single-type-returns-404-and-then-500/37345/4 |
What does it do?
After applying a change this pull request some cases has been missed like for example when the local is not default one and you want to create and publish
Why is it needed?
Because the user can not create or save any single type module so i just add another validation to check if the local exist or not
How to test it?
Create single types and collection type with localization enabled , look to you database you can see all data will be create depend of your current local and when you are going to publish it it says 404 because it can not find the record with that local in the database
Related issue(s)/PR(s)