Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: refactor filters #19739

Merged
merged 1 commit into from Mar 14, 2024
Merged

chore!: refactor filters #19739

merged 1 commit into from Mar 14, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • refactors the way filters work to be flatter and a composite component

Why is it needed?

  • filters were a mess that wanted too much data but didn't do anything with it. it also had barely an resemblance to the ListLayoutField it normally interacted with.

@joshuaellis joshuaellis added source: core:helper-plugin Source is core/helper-plugin package pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Mar 12, 2024
@joshuaellis joshuaellis added this to the 5.0.0 milestone Mar 12, 2024
@joshuaellis joshuaellis self-assigned this Mar 12, 2024
@joshuaellis joshuaellis requested review from simotae14 and removed request for jhoward1994 March 12, 2024 16:32
@joshuaellis
Copy link
Member Author

There's an infinite loop happening, but that just breaks the document actions, so we can probably still review this :)

simotae14
simotae14 requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@simotae14 simotae14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some minor comments, you can decide to use them or not because some are just personal preferences...I tested the filters and I found some errors, can you please check?

@joshuaellis
Copy link
Member Author

I've made the error state better but the issue you found is existing and known – #16554

@joshuaellis joshuaellis force-pushed the chore/helper-plugin-filters branch 5 times, most recently from b7e28c7 to e9623e7 Compare March 13, 2024 15:59
@joshuaellis joshuaellis force-pushed the chore/helper-plugin-filters branch 2 times, most recently from bea8501 to 4a79c1a Compare March 13, 2024 19:13
@joshuaellis joshuaellis merged commit 0f4345f into v5/main Mar 14, 2024
98 of 102 checks passed
@joshuaellis joshuaellis deleted the chore/helper-plugin-filters branch March 14, 2024 08:00
@echoes-hq echoes-hq bot added the echoes/type: maintenance/refactor For work refactoring tech debt or legacy work label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhurisandbhor madhurisandbhor Awaiting requested review from madhurisandbhor

@markkaylor markkaylor Awaiting requested review from markkaylor

@simotae14 simotae14 Awaiting requested review from simotae14

Assignees

@joshuaellis joshuaellis

Labels
echoes/type: maintenance/refactor For work refactoring tech debt or legacy work pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:helper-plugin Source is core/helper-plugin package
Projects
None yet
Milestone
5.0.0-beta.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaellis @simotae14