Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:issue on do not validate locale if not creating for all locales #19799

Merged
merged 11 commits into from
Mar 27, 2024
Merged

fix:issue on do not validate locale if not creating for all locales #19799

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8d28c58
fix:issue on do not validate locale if not creating for all locales
binar1 Mar 13, 2024
36afee6
Merge branch 'develop' into fix/i18n-can-not-publish-none-default-locale
binar1 Mar 16, 2024
b1274b8
Merge branch 'develop' into fix/i18n-can-not-publish-none-default-locale
binar1 Mar 19, 2024
d4aae58
Update register.ts
binar1 Mar 19, 2024
2169573
Merge branch 'develop' into fix/i18n-can-not-publish-none-default-locale
binar1 Mar 19, 2024
4a7a746
run prettier
binar1 Mar 25, 2024
57c666f
Merge branch 'develop' into fix/i18n-can-not-publish-none-default-locale
binar1 Mar 25, 2024
b8e1248
Merge branch 'develop' into fix/i18n-can-not-publish-none-default-locale
binar1 Mar 26, 2024
4f01b8f
change the syntax to handle more cases
binar1 Mar 26, 2024
0dd5746
Merge branch 'develop' into fix/i18n-can-not-publish-none-default-locale
binar1 Mar 26, 2024
187eaae
Merge branch 'develop' into fix/i18n-can-not-publish-none-default-locale
binar1 Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/plugins/i18n/server/src/register.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,17 @@ export default ({ strapi }: { strapi: Strapi }) => {
const isUrlForCreation = (url: string) => {
if (!url) return false;

// Remove any query params
// /content-manager/collection-types/api::category.category/?locale=en
const path = url.split('?')[0];

// Split path and remove empty strings
// [ 'content-manager', 'collection-types', 'api::category.category' ]
const splitUrl = url.split('/').filter(Boolean);
const splitUrl = path.split('/').filter(Boolean);

// Get the last element of the array
// api::category.category / 1 / publish

const model = splitUrl[splitUrl.length - 1];

// If the model contains :: it means it's a uid
Expand Down