enhancement!: create should send 201 status code #19869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerdvations
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
innerdvations
changed the title
innerdvations
added
source: core:strapi
jhoward1994
reviewed
Apr 12, 2024
jhoward1994
reviewed
Apr 12, 2024
packages/core/content-releases/server/src/controllers/__tests__/release-action.test.ts
Outdated
Show resolved
Hide resolved
innerdvations
changed the title
innerdvations
added
the
flag: 💥 Breaking change
jhoward1994
approved these changes
Apr 12, 2024
innerdvations
changed the title
innerdvations
added
pr: enhancement
christiancp100
approved these changes
Apr 15, 2024
echoes-hq
bot
added
the
echoes/type: feature/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
All create methods throughout strapi now use ctx.created, most importantly the content api. In cases I wasn't sure it was safe to use ctx.created I explicitly set status to 201
Why is it needed?
Create actions should result in a 201 http status code
How to test it?
All the updated tests test it pretty thoroughly.
But to test manually, the default status for a create action in a custom controller should be 201 so:
Admin API can essentially be tested the same way, just through different endpoints.
Related issue(s)/PR(s)
DX-1118