enhancement!: create should send 201 status code

packages/core/content-manager/server/src/controllers/collection-types.ts

@@ -232,6 +232,7 @@ export default {
     ]);
 
     const sanitizedDocument = await permissionChecker.sanitizeOutput(document);
+    ctx.status = 201;
     ctx.body = await documentMetadata.formatDocumentWithMetadata(model, sanitizedDocument, {
       // Empty metadata as it's not relevant for a new document
       availableLocales: false,

packages/core/content-releases/server/src/controllers/__tests__/release-action.test.ts

@@ -100,6 +100,7 @@ describe('Release Action controller', () => {
         params: {
           releaseId: 1,
         },
+        created: jest.fn(),
         request: {
           body: [
             {
@@ -123,9 +124,18 @@ describe('Release Action controller', () => {
       await releaseActionController.createMany(ctx);
 
       expect(mockCreateAction).toHaveBeenCalledTimes(2);
-      expect(ctx.body.data).toHaveLength(2);
-      expect(ctx.body.meta.totalEntries).toBe(2);
-      expect(ctx.body.meta.entriesAlreadyInRelease).toBe(0);
+
+      expect(ctx.created).toHaveBeenCalledWith(
+        expect.objectContaining({
+          data: expect.any(Array), // Ensure data is an array
+          meta: expect.objectContaining({
+            totalEntries: 2,
+            entriesAlreadyInRelease: 0,
+          }),
+        })
+      );
+      const firstCallArgument = ctx.created.mock.calls[0][0];
+      expect(firstCallArgument.data.length).toBe(2);
     });
 
     it('should count already added entries and dont throw an error', async () => {
@@ -139,6 +149,7 @@ describe('Release Action controller', () => {
         params: {
           releaseId: 1,
         },
+        created: jest.fn(),
         request: {
           body: [
             {
@@ -155,9 +166,10 @@ describe('Release Action controller', () => {
       await releaseActionController.createMany(ctx);
 
       expect(mockCreateAction).toHaveBeenCalledTimes(1);
-      expect(ctx.body.data).toHaveLength(0);
-      expect(ctx.body.meta.totalEntries).toBe(1);
-      expect(ctx.body.meta.entriesAlreadyInRelease).toBe(1);
+      expect(ctx.created).toHaveBeenCalledWith({
+        data: [],
+        meta: { totalEntries: 1, entriesAlreadyInRelease: 1 },
+      });
     });
   });
 

packages/core/content-releases/server/src/controllers/release-action.ts

@@ -26,9 +26,9 @@ const releaseActionController = {
     const releaseService = getService('release', { strapi });
     const releaseAction = await releaseService.createAction(releaseId, releaseActionArgs);
 
-    ctx.body = {
+    ctx.created({
       data: releaseAction,
-    };
+    });
   },
 
   async createMany(ctx: Koa.Context) {
@@ -64,13 +64,13 @@ const releaseActionController = {
 
     const newReleaseActions = releaseActions.filter((action) => action !== null);
 
-    ctx.body = {
+    ctx.created({
       data: newReleaseActions,
       meta: {
         entriesAlreadyInRelease: releaseActions.length - newReleaseActions.length,
         totalEntries: releaseActions.length,
       },
-    };
+    });
   },
 
   async findMany(ctx: Koa.Context) {

packages/core/content-releases/server/src/controllers/release.ts

@@ -120,9 +120,11 @@ const releaseController = {
       model: RELEASE_MODEL_UID,
     });
 
-    ctx.body = {
-      data: await permissionsManager.sanitizeOutput(release),
-    };
+    ctx.created({
+      body: {
+        data: await permissionsManager.sanitizeOutput(release),
+      },
+    });
   },
 
   async update(ctx: Koa.Context) {

packages/core/core/src/core-api/controller/collection-type.ts

@@ -66,6 +66,7 @@ const createCollectionTypeController = ({
 
       const sanitizedEntity = await this.sanitizeOutput(entity, ctx);
 
+      ctx.status = 201;
       return this.transformResponse(sanitizedEntity);
     },
 

packages/core/review-workflows/server/src/controllers/workflows.ts

@@ -59,9 +59,9 @@ export default {
       })
       .then(formatWorkflowToAdmin);
 
-    ctx.body = {
+    ctx.created({
       data: await sanitizeOutput(createdWorkflow),
-    };
+    });
   },
 
   /**

packages/core/upload/server/src/controllers/admin-folder.ts

@@ -94,9 +94,9 @@ export default {
       model: FOLDER_MODEL_UID,
     });
 
-    ctx.body = {
+    ctx.created({
       data: await permissionsManager.sanitizeOutput(folder),
-    };
+    });
   },
 
   async update(ctx: Context) {

packages/core/upload/server/src/controllers/admin-upload.ts

@@ -92,6 +92,7 @@ export default {
     const signedFiles = await async.map(uploadedFiles, getService('file').signFileUrls);
 
     ctx.body = await pm.sanitizeOutput(signedFiles, { action: ACTIONS.read });
+    ctx.status = 201;
   },
 
   // TODO: split into multiple endpoints

packages/core/upload/server/src/controllers/content-api.ts

@@ -138,6 +138,7 @@ export default ({ strapi }: { strapi: Core.Strapi }) => {
       });
 
       ctx.body = await sanitizeOutput(uploadedFiles as any, ctx);
+      ctx.status = 201;
     },
 
     // TODO: split into multiple endpoints

tests/api/core/content-manager/api/basic-compo-repeatable.test.api.js

@@ -78,7 +78,7 @@ describe('CM API - Basic + compo', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(product);
     expect(res.body.data.publishedAt).toBeDefined();
     data.productsWithCompo.push(res.body.data);

tests/api/core/content-manager/api/basic-compo.test.api.js

@@ -75,7 +75,7 @@ describe('CM API - Basic + compo', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(product);
     expect(res.body.data.publishedAt).toBeDefined();
     data.productsWithCompo.push(res.body.data);

tests/api/core/content-manager/api/basic-dp-compo-repeatable.test.api.js

@@ -81,7 +81,7 @@ describe('CM API - Basic + compo', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(product);
     expect(res.body.data.publishedAt).toBeNull();
     data.productsWithCompoAndDP.push(res.body.data);

tests/api/core/content-manager/api/basic-dp-compo.test.api.js

@@ -78,7 +78,7 @@ describe('CM API - Basic + compo', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(product);
     expect(res.body.data.publishedAt).toBeNull();
     data.productsWithCompoAndDP.push(res.body.data);
@@ -140,7 +140,7 @@ describe('CM API - Basic + compo', () => {
         body: product,
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data).toMatchObject(product);
       data.productsWithCompoAndDP.push(res.body.data);
     });
@@ -160,7 +160,7 @@ describe('CM API - Basic + compo', () => {
         body: product,
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data).toMatchObject(product);
       data.productsWithCompoAndDP.push(res.body.data);
     });
@@ -214,7 +214,7 @@ describe('CM API - Basic + compo', () => {
         body: product,
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data).toMatchObject(product);
       data.productsWithCompoAndDP.push(res.body.data);
     });

tests/api/core/content-manager/api/basic-dp-dz.test.api.js

@@ -81,7 +81,7 @@ describe('CM API - Basic + dz', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(product);
     expect(res.body.data.publishedAt).toBeNull();
     data.productsWithDzAndDP.push(res.body.data);
@@ -181,7 +181,7 @@ describe('CM API - Basic + dz', () => {
           body: product,
         });
 
-        expect(res.statusCode).toBe(200);
+        expect(res.statusCode).toBe(method === 'create' ? 201 : 200);
         expect(res.body.data).toMatchObject(product);
         data.productsWithDzAndDP.push(res.body.data);
       });
@@ -206,7 +206,7 @@ describe('CM API - Basic + dz', () => {
           body: product,
         });
 
-        expect(res.statusCode).toBe(200);
+        expect(res.statusCode).toBe(method === 'create' ? 201 : 200);
         expect(res.body.data).toMatchObject(product);
         data.productsWithDzAndDP.push(res.body.data);
       });
@@ -270,7 +270,7 @@ describe('CM API - Basic + dz', () => {
           body: product,
         });
 
-        expect(res.statusCode).toBe(200);
+        expect(res.statusCode).toBe(method === 'create' ? 201 : 200);
         expect(res.body.data).toMatchObject(product);
         data.productsWithDzAndDP.push(res.body.data);
       });

tests/api/core/content-manager/api/basic-dp.test.api.js

@@ -73,7 +73,7 @@ describe('CM API - Basic', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(product);
     expect(res.body.data.publishedAt).toBeNull();
     data.productsWithDP.push(res.body.data);
@@ -91,7 +91,7 @@ describe('CM API - Basic', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(_.omit(product, 'publishedAt'));
     expect(res.body.data.publishedAt).toBeNull();
     data.productsWithDP.push(res.body.data);
@@ -409,7 +409,7 @@ describe('CM API - Basic', () => {
         body: product,
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data).toMatchObject(product);
       data.productsWithDP.push(res.body.data);
     });
@@ -424,7 +424,7 @@ describe('CM API - Basic', () => {
         body: product,
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data).toMatchObject({
         ...product,
       });

tests/api/core/content-manager/api/basic-dz.test.api.js

@@ -79,7 +79,7 @@ describe('CM API - Basic + dz', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(product);
     expect(res.body.data.publishedAt).toBe(null);
     data.productsWithDz.push(res.body.data);

tests/api/core/content-manager/api/basic.test.api.js

@@ -68,7 +68,7 @@ describe('CM API - Basic', () => {
       body: product,
     });
 
-    expect(res.statusCode).toBe(200);
+    expect(res.statusCode).toBe(201);
     expect(res.body.data).toMatchObject(omit('hiddenAttribute', product));
     expect(res.body.data).not.toHaveProperty('hiddenAttribute');
     expect(res.body.data.publishedAt).toBeDefined();

tests/api/core/content-manager/components/repeatable-not-required-min-max.test.api.js

@@ -66,7 +66,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(Array.isArray(res.body.data.field)).toBe(true);
       expect(res.body.data.field).toEqual(
         expect.arrayContaining([
@@ -112,7 +112,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
     });
 
     test('Throws when sending too many items', async () => {
@@ -152,7 +152,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data.field).toEqual([]);
     });
   });

tests/api/core/content-manager/components/repeatable-not-required.test.api.js

@@ -61,7 +61,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(Array.isArray(res.body.data.field)).toBe(true);
       expect(res.body.data.field).toEqual(
         expect.arrayContaining([
@@ -96,7 +96,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data.field).toEqual([]);
     });
 
@@ -108,7 +108,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(res.body.data.field).toEqual([]);
     });
   });

tests/api/core/content-manager/components/repeatable-required-min-max.test.api.js

@@ -63,7 +63,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(Array.isArray(res.body.data.field)).toBe(true);
       expect(res.body.data.field).toEqual(
         expect.arrayContaining([
@@ -89,7 +89,7 @@ describe('Non repeatable and Not required component', () => {
         },
       });
 
-      expect(res.statusCode).toBe(200);
+      expect(res.statusCode).toBe(201);
       expect(Array.isArray(res.body.data.field)).toBe(true);
       expect(res.body.data.field).toEqual(
         expect.arrayContaining([