enhancement: add relation data to history versions response #20035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
added
source: core:content-manager
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
markkaylor
reviewed
Apr 4, 2024
packages/core/content-manager/shared/contracts/history-versions.ts
Outdated
Show resolved
Hide resolved
|
This looks interesting, could you share a quick screenshot of what this looks like? |
|
@derrickmehaffy the frontend isn't ready but it will look like this |
markkaylor
approved these changes
Apr 4, 2024
packages/core/content-manager/server/src/history/services/history.ts
Outdated
Show resolved
Hide resolved
packages/core/content-manager/server/src/history/services/history.ts
Outdated
Show resolved
Hide resolved
packages/core/content-manager/shared/contracts/history-versions.ts
Outdated
Show resolved
Hide resolved
Looks awesome thank you 😊 |
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ This PR replaces #19786, as the git history became too much of a mess on that one
What does it do?
Why is it needed?
We need to display relations in history. And showing that some relations were deleted requires special handling.
How to test it?
🚨 Because of the data structure change, your app may crash with pre-existing history versions 🚨
Create history versions with some relations. View history, you should see the data. Go delete the related content, you should see that too in the history frontend.