chore: adds and fixes e2e for content history #20098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
added
the
source: core:content-manager
remidej
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
remidej
force-pushed
the
chore/history-relations-e2e
branch
from
5666acb
to
b127991
Compare
markkaylor
reviewed
Apr 16, 2024
|
Yes I'm planning to come back to it after the beta and investigate the timeouts |
remidej
force-pushed
the
chore/history-relations-e2e
branch
from
0c72b6f
to
be360c3
Compare
remidej
changed the title
markkaylor
reviewed
May 27, 2024
Comment on lines
+44
to
+48
| const closeSuccessNotification = async (page: Page) => { | ||
| const successNotification = page.getByRole('alert', { name: /success/i }); | ||
| if (await successNotification.isVisible()) { | ||
| await successNotification.getByRole('button', { name: /close/i }).click(); | ||
| } |
There was a problem hiding this comment.
Not positive but it looks like this util might do the same thing, or is meant to do the same thing...
strapi/tests/e2e/utils/shared.ts
Lines 27 to 35 in f75e3c6
markkaylor
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Related issue(s)/PR(s)