fix(scheduling): update error message #20208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…g-update-error-message
…g-update-error-message
…g-update-error-message
Feranchz
added
pr: fix
Marc-Roig
approved these changes
Jul 3, 2024
remidej
reviewed
Jul 3, 2024
There was a problem hiding this comment.
I guess we're moving the validations because the backend wasn't using them?
There was a problem hiding this comment.
The backend use some of them but with different fields/formats, also in the front we want to throw translated errors and we can't do that on back so one for both don't work anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updates the scheduling required field error message to use more generic required field message.
Why is it needed?
Asked by UX, https://www.notion.so/strapi/Releases-Scheduling-Alpha-Blitz-Session-14ae56786d5a41e2a0dbf98b7e4b55e2?pvs=4#8916a056719f4dbb862c479bf1eab087
How to test it?
When user tries to schedule a release if any of the required field is not filled, on submit user should get error message This value is required.