feat(graphql): allow to pass cache hints to graphql fields #20254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
unrevised6419
commented
May 3, 2024
| 'options', | ||
| 'pluginOptions', | ||
| 'attributes', | ||
| 'pluginOptions', |
There was a problem hiding this comment.
Note: Removed duplicated value.
unrevised6419
commented
May 3, 2024
Comment on lines
101
to
106
| graphql?: { | ||
| cacheHint?: { | ||
| find?: CacheHint; | ||
| findOne?: CacheHint; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Question: Why is this field type not visible in find/findOne resolvers? 🤔
|
I will close this experiment PR for now. Might come to it at a later time or in v5. |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/how-can-we-configure-graphql-cachecontrol-with-shadowcrud/39842/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
2024-05-03.03-24-48.mp4
Why is it needed?
https://www.apollographql.com/docs/apollo-server/performance/caching/
Note: Strapi uses a previous major version of Apollo Server, which works similarly.
How to test it?
Provide information about the environment and the path to verify the behaviour.
To Do
nexus@nextand use directive as static instead of resolve