-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace plugin cli with external strapi/sdk-plugin package #20303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerdvations
added
source: cli
Source is cli package
flag: don't merge
This PR should not be merged at the moment
pr: chore
This PR contains chore tasks (cleanups, configs, tooling...)
labels
May 13, 2024
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
innerdvations
requested review from
Convly,
Bassel17,
joshuaellis and
jhoward1994
May 21, 2024 11:08
Size Change: 0 B Total Size: 2.52 MB ℹ️ View Unchanged
|
Convly
requested changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but there are conflicts probably due the latest release
innerdvations
removed
the
flag: don't merge
This PR should not be merged at the moment
label
May 24, 2024
Convly
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: chore
This PR contains chore tasks (cleanups, configs, tooling...)
source: cli
Source is cli package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes the plugin:* commands and their contributor docs, because they have been moved to @strapi/sdk-plugin
Why is it needed?
It is moving out of the monorepo into its own project
How to test it?
yarn build
should still build all the pluginsRelated issue(s)/PR(s)
Fixes have already been made to solve the "Tracking Issue: Strapi 5 plugin template currently out-of-date/incorrect", now found at strapi/sdk-plugin#1 they just need to be tested and released
DX-1406