Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:: uncaught error: FormModalHeader #20338

Closed
wants to merge 1 commit into from

Conversation

rajaadubey
Copy link

@rajaadubey rajaadubey commented May 20, 2024

What does it do?

added null check

Why is it needed?

there is null check

Related issue(s)/PR(s)

#20339

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ❌ Failed (Inspect) May 20, 2024 10:00am

@strapi-cla
Copy link

strapi-cla commented May 20, 2024

CLA assistant check
All committers have signed the CLA.

@joshuaellis
Copy link
Member

Can you fill out the template in detail please, e.g. how do we reproduce the bug, how do we test, how did you come to this solution etc.

@joshuaellis joshuaellis added the flag: don't merge This PR should not be merged at the moment label May 20, 2024
@rajaadubey
Copy link
Author

Can you fill out the template in detail please, e.g. how do we reproduce the bug, how do we test, how did you come to this solution etc.

updated issue #20339

@joshuaellis
Copy link
Member

Can you fill out the template in detail please, e.g. how do we reproduce the bug, how do we test, how did you come to this solution etc.

updated issue #20339

PRs are a form of history, and your current description is lacking how you came to your conclusion, for example at the moment im not convinced on your solution, it just masks the issue, why is the schema null there when it should be defined at this point? etc.

@alexandrebodin
Copy link
Member

Important

With the release of Strapi 5, we have lifted the code freeze. To ensure we can effectively review and assist with contributions, we are now only accepting PRs targeting version 5 (the develop branch).

As your PR is targeting some of the most recent v4 version, We we would greatly appreciate it if you could update your contribution to align with version 5 and resubmit!

@hanpaine
Copy link
Contributor

Original Issue ticket has been closed as unable to reproduce and no response on this ticket since May so closing

@hanpaine hanpaine closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: don't merge This PR should not be merged at the moment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants