Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API prefix #2056

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Remove API prefix #2056

merged 1 commit into from
Oct 2, 2018

Conversation

lauriejim
Copy link
Contributor

My PR is a: 💅 Enhancement
Main update on the: Framework

Actually we allow by default an router option prefix because it was possible by the router we use in Strapi. But it cause issues with Public files and Admin so we chose to remove the possibility to prefix all routes.

Related issue #1323

@lauriejim lauriejim added pr: 💅 Enhancement source: core:strapi Source is core/strapi package labels Oct 2, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.14.3 milestone Oct 2, 2018
@lauriejim lauriejim self-assigned this Oct 2, 2018
@lauriejim lauriejim requested review from Aurelsicoko and soupette and removed request for Aurelsicoko October 2, 2018 14:51
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim lauriejim merged commit 98bd2d7 into master Oct 2, 2018
@lauriejim lauriejim deleted the update-prefix-doc branch October 2, 2018 14:53
@derrickmehaffy
Copy link
Member

@lauriejim assuming there will be some kind of versioning feature in the future?

@lauriejim
Copy link
Contributor Author

Yap that is correct !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants