Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for cloning locally from Heroku #2091

Merged
merged 3 commits into from
Oct 7, 2018
Merged

Add instructions for cloning locally from Heroku #2091

merged 3 commits into from
Oct 7, 2018

Conversation

endymion1818
Copy link
Contributor

Hi 👋

I really love Strapi and have been using it for a few months. I think you have all done a great job!

My PR is an: 💅 Enhancement

Main update on the: Documentation

This took me ages of trial & error when I first started investigating Strapi. I nearly gave up several times because of my inexperience with both Strapi and Heroku.

The only available instructions I found to be a bit difficult to follow (https://help.heroku.com/XOBUHLKQ/why-do-i-see-a-message-you-appear-to-have-cloned-an-empty-repository-when-using-heroku-git-clone).

I think this addition would help new adopters to get a more useful instance of Strapi running that would help them more easily evaluate the benefits of the content builder.

This took me ages of trial & error effort when I first started investigating Strapi. I nearly gave up several times. The only available instructions are a bit difficult to follow (https://help.heroku.com/XOBUHLKQ/why-do-i-see-a-message-you-appear-to-have-cloned-an-empty-repository-when-using-heroku-git-clone).

I think this addition would help new adopters to get a more useful instance of Strapi running that would help them more easily evaluate the benefits of the content builder.
@endymion1818 endymion1818 changed the title Add instructions for cloning locally from Heroku [Docs] Add instructions for cloning locally from Heroku Oct 6, 2018
@maturanomx
Copy link
Contributor

Looks good 👍 ...

I just had one question due to my inexpertise with heroku, but I answered myself 😅

My questions was if not the step 4 (git remote add origin) cause a conflict with step 2 (heroku git:clone -a) due to the name of the remote reference. But it could be read in the heroku site this clone the repository "as well as adding a heroku git remote to facilitate further updates".

So, makes no conflict. Good to know 👍

@endymion1818
Copy link
Contributor Author

endymion1818 commented Oct 7, 2018

Hmm you might be right about that! I was working from memory and might have got it wrong. I will run through the process again to make sure I have it correct I will comment again to confirm.

@endymion1818
Copy link
Contributor Author

Updated - thanks for the heads up @maturanomx !

@lauriejim lauriejim self-requested a review October 7, 2018 15:08
@lauriejim lauriejim self-assigned this Oct 7, 2018
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update!

@lauriejim lauriejim added this to the 3.0.0-alpha.14.3 milestone Oct 7, 2018
@lauriejim lauriejim merged commit d8a2c9a into strapi:master Oct 7, 2018
@lauriejim lauriejim changed the title [Docs] Add instructions for cloning locally from Heroku Add instructions for cloning locally from Heroku Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants