Improve code style and code quality #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maturanomx
commented
Oct 23, 2018
| @@ -16,19 +16,11 @@ const LodashModuleReplacementPlugin = require('lodash-webpack-plugin'); | |||
|
|
|||
| const isAdmin = process.env.IS_ADMIN === 'true'; | |||
| const isSetup = path.resolve(process.env.PWD, '..', '..') === path.resolve(process.env.INIT_CWD); | |||
There was a problem hiding this comment.
Maybe this should be const isSetup = process.env.IS_MONOREPO || false;, same as in other files 🤔
jbergstroem
reviewed
Oct 24, 2018
lauriejim
added
pr: 💅 Enhancement
source: core:strapi
lauriejim
requested review from
soupette
and removed request for
Aurelsicoko and
lauriejim
Just some little improvements that I found looking around the code. Related 2410d5a
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some little improvements that I found looking around the code.
Related 2410d5a
My PR is a:
💅 Enhancement
Main update on the:
Framework