Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo documentation & update RU translations #2401

Merged
merged 3 commits into from Nov 30, 2018
Merged

Fix typo documentation & update RU translations #2401

merged 3 commits into from Nov 30, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2018

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix #issueNumber
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

@derrickmehaffy
Copy link
Member

derrickmehaffy commented Nov 29, 2018

Good catch, if you don't mind can I have you throw another typo in this PR?

Can you stick this bit:

#### Relations
 You can also use filters into a relation attribute which will be applied to the first level of the request.
 Find users having written a post named `Title`.
 
 `GET /users?posts.name=Title`
 
 Find posts written by a user having more than 12 years old.
 
 `GET /posts?author.age_gt=12`
 
 > Note: You can't use filter to have specific results inside relation, like "Find users and only their posts older than yesterday" as example. If you need it, you can modify or create your own service or use [GraphQL](./graphql.md#query-api).

 > Warning: this filter isn't available for `upload` plugin

In: https://github.com/strapi/strapi/edit/master/docs/3.x.x/guides/filters.md

I made a few fixes there, and easier than creating another PR 😛

@lauriejim lauriejim self-requested a review November 30, 2018 14:46
@lauriejim lauriejim self-assigned this Nov 30, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.16 milestone Nov 30, 2018
@lauriejim lauriejim changed the title Fix typo Fix typo documentation & update RU translations Nov 30, 2018
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for this update!

@lauriejim lauriejim merged commit 9bcbd61 into strapi:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants