Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Apollo server tracing in GraphQL #2485

Merged
merged 5 commits into from
Dec 21, 2018
Merged

Add support for Apollo server tracing in GraphQL #2485

merged 5 commits into from
Dec 21, 2018

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Dec 14, 2018

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

This adds support for the Apollo server tracing feature to assist users and developers track parts of a graphQL query to see where any latency is happening.

By default it is off, but can be enabled if needed.

@derrickmehaffy derrickmehaffy changed the title [WIP] Add support for Apollo server tracing in GraphQL Add support for Apollo server tracing in GraphQL Dec 14, 2018
@derrickmehaffy
Copy link
Member Author

@lauriejim This PR is a simple one just add another config option to GraphQL to support time traces on specific queries. It can dramatically increase the size of the response but is disabled by default so there should be no breaking issues if you wanted to include this in the next release.

@lauriejim lauriejim added pr: 🚀 New feature source: core:content-manager Source is core/content-manager package labels Dec 18, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.18 milestone Dec 18, 2018
@lauriejim
Copy link
Contributor

I will let @Aurelsicoko take the decision about that.

@Aurelsicoko
Copy link
Member

LGTM 👍

@lauriejim lauriejim merged commit 335503b into master Dec 21, 2018
@lauriejim lauriejim deleted the fix/2437 branch December 21, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants