Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $pull error deleting entry with dominant model of many-to-many relation #2812

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

gilhardl
Copy link
Contributor

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres

Description:
fix $pull error deleting entry with dominant model of many-to-many relation by bypassing associations entries update if dominant

fix #2731

fix $pull error deleting entry with dominant model of many-to-many relation by bypassing associations entries update if dominant

fix strapi#2731
@lauriejim lauriejim added pr: 🐛 Bug fix source: core:strapi Source is core/strapi package labels Feb 18, 2019
@lauriejim lauriejim self-assigned this Mar 8, 2019
@lauriejim lauriejim added this to the 3.0.0-alpha.25 milestone Mar 8, 2019
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yap that's good! Thank you for this PR!

@lauriejim lauriejim changed the title fix $pull error deleting entry with dominant model of many-to-many relation Fix $pull error deleting entry with dominant model of many-to-many relation Mar 8, 2019
@lauriejim lauriejim merged commit a5ce7bc into strapi:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$pull error deleting entry with dominant model of many-to-many relation
2 participants