Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sqlite column update #2826

Merged
merged 4 commits into from
Feb 16, 2019
Merged

Fix sqlite column update #2826

merged 4 commits into from
Feb 16, 2019

Conversation

lauriejim
Copy link
Contributor

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

Description:

When you update / create a new attribute on SQLite the function we use (ALTER COLUMN) doesn't work on SQLite but works with MySQL and Postgres.

So we manage attribute creation / update on SQLite.

@lauriejim lauriejim added pr: 🐛 Bug fix source: core:strapi Source is core/strapi package labels Feb 14, 2019
@lauriejim lauriejim added this to the 3.0.0-alpha.24 milestone Feb 14, 2019
derrickmehaffy
derrickmehaffy requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this yet, but will do so today. Few minor grammar fixes. 😛

packages/strapi-hook-bookshelf/lib/index.js Outdated Show resolved Hide resolved
packages/strapi-hook-bookshelf/lib/index.js Outdated Show resolved Hide resolved
packages/strapi-hook-bookshelf/lib/index.js Outdated Show resolved Hide resolved
Aurelsicoko
Aurelsicoko approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@Aurelsicoko Aurelsicoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim
Copy link
Contributor Author

I'm fixing @derrickmehaffy feedback then I merge this PR

@lauriejim lauriejim merged commit 3e92b59 into master Feb 16, 2019
@lauriejim lauriejim deleted the fix-sqlite-update-column branch February 16, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickmehaffy derrickmehaffy derrickmehaffy requested changes

@Aurelsicoko Aurelsicoko Aurelsicoko approved these changes

Assignees

@Aurelsicoko Aurelsicoko

Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
3.0.0-alpha.24
Development

Successfully merging this pull request may close these issues.

Error: SQLITE_ERROR: near "ALTER": syntax error
3 participants
@lauriejim @Aurelsicoko @derrickmehaffy