Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong param name in getType bookshelf hook #3401

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Fix wrong param name in getType bookshelf hook #3401

merged 2 commits into from
Jun 10, 2019

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Jun 7, 2019 •
edited
Loading

Description of what you did:

Fix Sqlite non-constant defalt

Fixes #2930

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@alexandrebodin alexandrebodin added pr: 🐛 Bug fix source: core:strapi Source is core/strapi package labels Jun 7, 2019
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.4 milestone Jun 7, 2019
@alexandrebodin alexandrebodin force-pushed the fix/sqlite-non-constant-default-timestamp branch from 2fe0071 to e916086 Compare June 8, 2019 16:51
lauriejim
lauriejim approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 33cbe98 into master Jun 10, 2019
@alexandrebodin alexandrebodin deleted the fix/sqlite-non-constant-default-timestamp branch June 10, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauriejim lauriejim lauriejim approved these changes

@derrickmehaffy derrickmehaffy Awaiting requested review from derrickmehaffy

Assignees
No one assigned
Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Milestone
3.0.0-beta.4
Development

Successfully merging this pull request may close these issues.

SQLITE_ERROR: Cannot add a column with non-constant default
2 participants
@alexandrebodin @lauriejim