Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GA in the docs #4620

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Add GA in the docs #4620

merged 1 commit into from
Nov 28, 2019

Conversation

lauriejim
Copy link
Contributor

Description of what you did:

During the migration to VuePress 1, the Google Analytics was moved in a plugin.
So I forgot to update this part.

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

alexandrebodin
alexandrebodin approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim lauriejim added this to the 3.0.0-beta.17.7 milestone Nov 28, 2019
@lauriejim lauriejim merged commit d1326aa into master Nov 28, 2019
@lauriejim lauriejim deleted the docs-ga branch November 28, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees
No one assigned
Labels
source: docs Documentation changes
Projects
None yet
Milestone
3.0.0-beta.17.7
Development

Successfully merging this pull request may close these issues.
2 participants
@lauriejim @alexandrebodin