Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo on mongo image #5398

Merged
merged 2 commits into from Mar 6, 2020
Merged

Fixes typo on mongo image #5398

merged 2 commits into from Mar 6, 2020

Conversation

dstrants
Copy link
Contributor

@dstrants dstrants commented Mar 3, 2020

Description of what you did:

Hello!

I was exploring the docs and found out a tiny but important issue on the instructions. The MongoDB part was calling the Postgres image inside the indicative docker-compose.yaml

@lauriejim lauriejim changed the title fixes typo on mongo image Fixes typo on mongo image Mar 5, 2020
lauriejim
lauriejim previously approved these changes Mar 5, 2020
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!
As you said, little but big issue.
LGTM

@lauriejim
Copy link
Contributor

Can you please just check the CDO please:

https://github.com/strapi/strapi/pull/5398/checks?check_run_id=483161125

@lauriejim lauriejim added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 5, 2020
Signed-off-by: Dimitrios Strantsalis <dstrants@gmail.com>
@dstrants
Copy link
Contributor Author

dstrants commented Mar 5, 2020

Hello @lauriejim,
sorry I am not familiar with DCO and thought it wasn't me :)
It looks fine now.

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 6, 2020
@alexandrebodin alexandrebodin merged commit 8b50b04 into strapi:master Mar 6, 2020
@strapi strapi deleted a comment from codecov bot Mar 6, 2020
@dstrants dstrants deleted the patch-1 branch March 6, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants